Skip to content

Support ignoring whitespace in diffs#160

Merged
ericmj merged 1 commit into
hexpm:mainfrom
dl-alexandre:ignore-whitespace-diffs
May 9, 2026
Merged

Support ignoring whitespace in diffs#160
ericmj merged 1 commit into
hexpm:mainfrom
dl-alexandre:ignore-whitespace-diffs

Conversation

@dl-alexandre
Copy link
Copy Markdown
Contributor

Summary

  • Add ?w=1 support to generate diffs with git diff -w.
  • Add a whitespace toggle link on diff pages.
  • Keep whitespace-ignored diff results in a separate cache key.

Tests

  • mix test

Closes #100

@ericmj ericmj merged commit c2cd280 into hexpm:main May 9, 2026
8 checks passed
@ericmj
Copy link
Copy Markdown
Member

ericmj commented May 9, 2026

Thank you! 💜

ericmj added a commit to paulo-valim/diff that referenced this pull request May 15, 2026
The branch was rebased over hexpm#160 ("Support ignoring whitespace in
diffs") which added the diff_options/ignore_whitespace? helpers and
the whitespace_toggle_label/whitespace_toggle_url view helpers. Wire
the toggle into the new Tailwind stats header so ?w=1 retains the
visible UI it had on the legacy template.

The pluralize/3 helper turns the singular case (1 file) into "file",
so test assertions for "files changed" can't match for total=1.
Loosen the matcher to "changed" and switch the lingering :timer.sleep
spot to assert_eventually.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip whitespace changes

2 participants